-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robustify spawner (backport #1501) #1686
Conversation
Cherry-pick of 80c264f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1686 +/- ##
==========================================
+ Coverage 62.27% 62.28% +0.01%
==========================================
Files 105 105
Lines 11295 11314 +19
Branches 7910 7928 +18
==========================================
+ Hits 7034 7047 +13
- Misses 807 808 +1
- Partials 3454 3459 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
With the current implementation it can happen that when using multiple controller spawners some of them fail or get stuck, see #1182. This fixes #1182 and #1483.
While writing this, I realize this has great overlap with #1483, but I see no problem combining those two.
As briefly mentioned above, this change addresses two things:
Note: The test I implemented is a bit hacky, so we might also want to remove it again? Otherwise I think we would have to change the following things:
test
folder in order to access the controller configuration file living in there. We should either install that file by hand rather than the complete test folder or move it somewhere else.ros_control_test_assets
as I thought that might be the most useful place. I might be wrong.I implemented and tested things on the rolling on jammy installation I currently have, but I know the problem definitively also arises for humble users.
This is an automatic backport of pull request #1501 done by Mergify.